Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILProcessor should also update custom debug info #867

Merged
merged 2 commits into from
Sep 29, 2022
Merged

ILProcessor should also update custom debug info #867

merged 2 commits into from
Sep 29, 2022

Commits on Jun 29, 2022

  1. ILProcessor should also update custom debug info (jbevain#34) 

    * ILProcessor should also update custom debug info

When eidting IL with ILProcessor various pieces of debug information have references to the origin IL instructions. These references can be either resolved (point to Instruction instance), in which case the editting mostly works, or unresolved (store IL offset only) in which case they need to be resolved before the editting can occur (after the edit the original IL offsets are invalid and unresolvable).

This is effectively a continuation of jbevain#687 which implemented this for local scopes. This change extends this to async method stepping info and state machine scopes.

The change refactors the code to make it easier to reuse the same logic between the various debug infos being processed.

Updated the existing tests from jbevain#687 to include async and state machine debug info (completely made up) and validate that it gets updated correctly.

* PR Feedback

Renamed some parameters/locals to better match the existing code style.

* PR Feedback
    @vitek-karas
    vitek-karas committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    3364063 View commit details
    Browse the repository at this point in the history

  2. Fix test on Linux 

    Native PDB is not supported on Linux and the test infra falls back to portable PDB automatically. Since the two PDB implementations read the custom debug info from a different place the test constructing the input needs to adapt to this difference as well.
    @vitek-karas
    vitek-karas committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2f47d20 View commit details
    Browse the repository at this point in the history