Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated dplyr functions #637

Merged
merged 4 commits into from
Jul 5, 2020
Merged

Update deprecated dplyr functions #637

merged 4 commits into from
Jul 5, 2020

Conversation

hdrab127
Copy link
Contributor

Hey there's quite a few changes here but they are all just replacing group_by_, mutate_, select_ etc. with their NSE equivalents (using !!, !!! where needed). And also replacing tbl_df with tibble::as_tibble as recommended by dplyr.

This removes all the warnings like

Warning messages:
1: group_by_() is deprecated as of dplyr 0.7.0.
Please use group_by() instead.
See vignette('programming') for more help

I've tested the examples on the web page and all seems to work, hopefully haven't missed anything.

Note: I didn't look at any of the files in dev/

When RStudio rebuilt the vignettes it failed the Mac tests, not sure what went wrong there sorry.

Thanks for the awesome repo!
Hayden

@jbkunst jbkunst merged commit e33985c into jbkunst:master Jul 5, 2020
@jbkunst
Copy link
Owner

jbkunst commented Jul 8, 2020

@hdrab127

Thanks so much for this PR!

Please send, if you want, a PR for add you to the package contributors in the DESCRIPTION file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants