Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): use octokit.rest.repos instead of octokit.repos #253

Merged
merged 9 commits into from
Dec 23, 2022

Conversation

lucasfernog
Copy link
Contributor

Motivation

It is wrong on @actions/core v5. We already fixed it on octokit.issues usages, but this was missing.

Approach

Typed the octokit argument and fixed the usage.

Alternate Designs

Possible Drawbacks or Risks

TODOs and Open Questions

Learning

Screenshots

Copy link
Owner

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better typing ended up exposing the fact that we missed updating the mocks in the tests. So I think we have it all squared away now.

@jbolda jbolda merged commit 3714905 into jbolda:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants