Handle unknown DNS lookup failure (#80)

Handles any exception when failing to lookup the SRV record for the default realm. The error will still be shown when the value is used but now the module will still import.
jborean93 · Mar 28, 2024 · 921e2fa · 921e2fa
1 parent 90f92c2
commit 921e2fa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog for PSOpenAD
 
+## v0.5.1 - TBD
+
++ Ensure a failure in a DNS lookup does not stop the module from importing but only errors when the value is used.
+
 ## v0.5.0 - 2024-03-21
 
 + Added the following cmdlets:

diff --git a/module/PSOpenAD.psd1 b/module/PSOpenAD.psd1
@@ -14,7 +14,7 @@
     RootModule             = 'PSOpenAD.psm1'
 
     # Version number of this module.
-    ModuleVersion          = '0.5.0'
+    ModuleVersion          = '0.5.1'
 
     # Supported PSEditions
     # CompatiblePSEditions = @()

diff --git a/src/PSOpenAD.Module/OnImportAndRemove.cs b/src/PSOpenAD.Module/OnImportAndRemove.cs
@@ -217,7 +217,11 @@ public void OnImport()
                         }
                         catch (DnsResponseException e)
                         {
-                            GlobalState.DefaultDCError = $"Error looking up SRV records for _ldap._tcp.{baseDomain}: {e.Message}";
+                            GlobalState.DefaultDCError = $"DNS Error looking up SRV records for _ldap._tcp.{baseDomain}: {e.Message}";
+                        }
+                        catch (Exception e)
+                        {
+                            GlobalState.DefaultDCError = $"Unknown error looking up SRV records for _ldap._tcp.{baseDomain}: {e.GetType().Name} - {e.Message}";
                         }
                     }
                 }