Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DFS file opens #190

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Improve DFS file opens #190

merged 2 commits into from
Aug 22, 2022

Conversation

jborean93
Copy link
Owner

Ensure that opening a file on a DFS marked share contains the
SMB2_FLAGS_DFS_OPERATIONS flag and create filename contains the DFS path
to parse and not just the tree relative path.

Related #170.

Ensure that opening a file on a DFS marked share contains the
SMB2_FLAGS_DFS_OPERATIONS flag and create filename contains the DFS path
to parse and not just the tree relative path.
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #190 (53f2e33) into master (bc401b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          24       24           
  Lines        5069     5076    +7     
=======================================
+ Hits         5023     5030    +7     
  Misses         46       46           
Flag Coverage Δ
macOS 68.20% <25.00%> (-0.06%) ⬇️
py3.10 99.07% <100.00%> (+<0.01%) ⬆️
py3.7 99.07% <100.00%> (+<0.01%) ⬆️
py3.8 99.07% <100.00%> (+<0.01%) ⬆️
py3.9 99.09% <100.00%> (+<0.01%) ⬆️
ubuntu 96.78% <100.00%> (+<0.01%) ⬆️
windows 99.01% <100.00%> (+<0.01%) ⬆️
x64 99.09% <100.00%> (+<0.01%) ⬆️
x86 99.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/_io.py 99.03% <100.00%> (+<0.01%) ⬆️
src/smbclient/_os.py 98.48% <100.00%> (ø)
src/smbprotocol/connection.py 99.84% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant