Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal changes make IDEA 2023.2 work out-of-box #470

Merged
merged 1 commit into from
Dec 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.2</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very significant change,Many JDK8 projects may not be able to upgrade dependencies.
I think this will reduce compatibility, it seems unnecessary.

<source>11</source>
<target>11</target>
<testSource>11</testSource>
<testTarget>11</testTarget>
<testCompilerArgument>-parameters</testCompilerArgument>
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/Bench.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
import javassist.compiler.*;

public class Bench extends JvstTestRoot {
public Bench(String name) {
super(name);
}

public void testProceed() throws Exception {
CtClass cc = sloader.get("test.BenchProceed");
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/JvstTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ public class JvstTest extends JvstTestRoot {
java9 = javassist.bytecode.ClassFile.MAJOR_VERSION
>= javassist.bytecode.ClassFile.JAVA_9;
}
public JvstTest(String name) {
super(name);
}

public void testConfig() {
// is the value of PATH correct?
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/JvstTest2.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
@SuppressWarnings({"rawtypes","unused"})
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
public class JvstTest2 extends JvstTestRoot {
public JvstTest2(String name) {
super(name);
}

public void testInsertAt() throws Exception {
CtClass cc = sloader.get("test2.InsertAt");
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/JvstTest3.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@

@SuppressWarnings({"rawtypes","unchecked","unused"})
public class JvstTest3 extends JvstTestRoot {
public JvstTest3(String name) {
super(name);
}

public void testAnnotation() throws Exception {
CtClass cc = sloader.get("test3.AnnoTest");
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/JvstTest4.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
@SuppressWarnings({"rawtypes","unchecked","unused"})
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
public class JvstTest4 extends JvstTestRoot {
public JvstTest4(String name) {
super(name);
}

public void testInsertLocalVars() throws Exception {
CtClass cc = sloader.get("test4.LocalVars");
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/JvstTest5.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@

@SuppressWarnings({"rawtypes","unchecked","unused"})
public class JvstTest5 extends JvstTestRoot {
public JvstTest5(String name) {
super(name);
}

public void testDollarClassInStaticMethod() throws Exception {
CtClass cc = sloader.makeClass("test5.DollarClass");
Expand Down
4 changes: 0 additions & 4 deletions src/test/javassist/JvstTestRoot.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ public class JvstTestRoot extends TestCase {
ClassPool sloader, dloader;
Loader cloader;

public JvstTestRoot(String name) {
super(name);
}

protected void print(String msg) {
System.out.println(msg);
}
Expand Down
3 changes: 0 additions & 3 deletions src/test/javassist/bytecode/InsertGap0.java
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,6 @@ public int run2(int x) {

@SuppressWarnings({"rawtypes","unchecked","unused"})
public final class InsertGap0 extends JvstTestRoot {
public InsertGap0(String name) {
super(name);
}

public void testExample() throws Throwable {
ClassPool pool = ClassPool.getDefault();
Expand Down
Loading