Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the standard compile plugin by default #109

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

stuartwdouglas
Copy link
Contributor

This will now only used the forked version of the plugin if a profile
has been activated that uses additionalClasspathElements.

This will now only used the forked version of the plugin if a profile
has been activated that uses additionalClasspathElements.
@stuartwdouglas
Copy link
Contributor Author

@dmlloyd who usually merges and releases this project? I think I technically have permissions, but I have not done it before.

@dmlloyd
Copy link
Member

dmlloyd commented Nov 4, 2021

Sorry, I missed this in my email. I think @jamezp did the last few. I've done tags in the past but "the old way" (releasing through repository.jboss.org and not making a GitHub release) which might or might not still be okay.

@jamezp jamezp merged commit 6c4b827 into jboss:main Nov 4, 2021
@jamezp
Copy link
Member

jamezp commented Nov 4, 2021

I've merged it. I've never done a release, but I assume it's just a standard release so I can if needed. It's been nearly 1.5 years since 38 was released so we're likely due :)

@dmlloyd
Copy link
Member

dmlloyd commented Nov 4, 2021

Sorry, I just went off the fact that your name was on the tag. I wonder if we want to start moving projects like this one towards releasing directly to central. It's possible to configure GitHub to do the work for us (that's what SmallRye does).

@jamezp
Copy link
Member

jamezp commented Nov 4, 2021

No worries. I don't think anyone really "owns" it. If you've got instructions on how to do that I'm all game. I tried to do it for a RESTEasy project and need proof I owned jboss.org.

@stuartwdouglas
Copy link
Contributor Author

If it is just released through JBoss Nexus then I can do it if needed. That is not going to be a long term solution though.

@jamezp
Copy link
Member

jamezp commented Nov 4, 2021

Either way works. I'm happy to do it or feel free. I'm not sure how we're going to handle this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants