Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[114] Add doc to change default behaviour to resolve jboss parent pom #115

Merged
merged 1 commit into from
Mar 14, 2022
Merged

[114] Add doc to change default behaviour to resolve jboss parent pom #115

merged 1 commit into from
Mar 14, 2022

Conversation

boris-unckel
Copy link
Contributor

Fixes #114

dmlloyd
dmlloyd reviewed Mar 14, 2022
View reviewed changes
README.adoc Outdated
@@ -28,7 +28,9 @@ Start out by adding the parent configuration to your pom.
<parent>
<groupId>org.jboss</groupId>
<artifactId>jboss-parent</artifactId>
<version>33</version>
<version>39</version>
<!-- The empty relativePath makes Maven lookup it in the repository. Missing tag default is ../pom.xml. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- The empty relativePath makes Maven lookup it in the repository. Missing tag default is ../pom.xml. -->
<!-- The empty relativePath makes Maven look it up in the repository. Missing tag default is ../pom.xml. -->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback, it's fixed now.

@dmlloyd dmlloyd merged commit 01a5bf2 into jboss:main Mar 14, 2022
@boris-unckel boris-unckel deleted the 114_add_usage_doc branch March 14, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default behaviour to resolve jboss parent pom
2 participants
@boris-unckel @dmlloyd