Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP create with extension json creates a pom with the wrong dependency #441

Closed
tqvarnst opened this issue Jan 7, 2019 · 2 comments
Closed
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@tqvarnst
Copy link
Contributor

tqvarnst commented Jan 7, 2019

Problem description

When using shamrock-maven-plugin:create with Json extension the pom.xml created adds a dependency to resteasy-jackson2-provider, which should be shamrock-jaxrs-deployment.

How to reproduce

  1. Create an empty directory
mkdir json-test && cd json-test
  1. Create a shamrock project with json extension
mvn org.jboss.shamrock:shamrock-maven-plugin:0.4.0:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=input-validation \
    -DclassName="org.acme.validation.BookResource" \
    -Dextensions="json"
  1. Compile the project
mvn compile

Expected outcome

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

Actual Outcome

[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.jboss.resteasy:resteasy-jackson2-provider:jar is missing. @ line 44, colum
n 17
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project org.acme:input-validation:1.0-SNAPSHOT (/Users/tqvarnst/tmp/test2/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for org.jboss.resteasy:resteasy-jackson2-provider:jar is missing. @ line 44, column 17
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException

Workaround

In the pom.xml change the dependency from org.jboss.resteasy:resteasy-jackson2-provider to org.jboss.shamrock:shamrock-jaxrs-deployment, which will pull in the correct json-b package.

@cescoffier cescoffier added this to the 0.5.0 milestone Jan 7, 2019
@cescoffier cescoffier added the kind/bug Something isn't working label Jan 7, 2019
@cescoffier cescoffier self-assigned this Jan 7, 2019
@cescoffier
Copy link
Member

So there are 2 things:

  1. it's a bug in the Extensions class - and this must be fixed.
  2. At some point we want out BOM to include more than just shamrock artifacts (typically important dependencies that should not diverge).

@gsmet
Copy link
Member

gsmet commented Jan 8, 2019

Fixed by #442 .

@gsmet gsmet closed this as completed Jan 8, 2019
maxandersen added a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants