Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #374 remove legacy build and native-image mojos #375

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

aloubyansky
Copy link
Member

No description provided.

@aloubyansky aloubyansky changed the title remove legacy build and native-image mojos #374 Fixes #374 remove legacy build and native-image mojos Dec 21, 2018
@@ -23,6 +23,7 @@
import org.apache.maven.plugin.MojoFailureException;
import org.apache.maven.plugins.annotations.Mojo;
import org.apache.maven.plugins.annotations.Parameter;
import org.jboss.shamrock.creator.phase.nativeimage.ReportAnalyzer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this import?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cescoffier The class has moved to creator module since NativeImagePhase needs it there.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment.

@aloubyansky aloubyansky merged commit e3529ed into quarkusio:master Dec 21, 2018
@cescoffier cescoffier added this to the 0.3.0 milestone Dec 24, 2018
maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants