Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmallRye Config to 1.9.0 #12172

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Update SmallRye Config to 1.9.0 #12172

merged 1 commit into from
Sep 18, 2020

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Sep 17, 2020

We do have quite a few changes in 1.9.0: https://github.com/smallrye/smallrye-config/releases/tag/1.9.0

Let me resume here:

#396 Cache EnvConfigSource. For #11782
#394 Bump snakeyaml from 1.26 to 1.27.
#392 Convert YAML keys to String. For #12036
#388 Bump version.smallrye.common from 1.3.0 to 1.4.0
#387 Fix Converter Priority and add unit test.
#375 ConfigSourceProvider injects unsorted map of Config Sources
#356 Add new default converter for java.util.UUID
#343 Add Currency converter
#342 Add BitSet Converter
#334 ConfigException parameters need re-ordering
#333 Configuration Mapper. New feature: https://smallrye.io/docs/smallrye-config/mapping/mapping.html
#313 Initial work to mix sources and interceptors priorities.
#283 Add API to specify default values
#196 Ability to use already retrieved Config in configuring things further down the chain. For #10390

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a minor comment (more like a question) :)

gsmet
gsmet previously requested changes Sep 17, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be squashed into 1 commit. The two commits are interdependent and it won't build with only one commit.

@radcortez
Copy link
Member Author

I think it should be squashed into 1 commit. The two commits are interdependent and it won't build with only one commit.

Sure. Done!

@gsmet gsmet dismissed their stale review September 17, 2020 19:00

Addressed.

@gastaldi gastaldi added this to the 1.9.0 - master milestone Sep 18, 2020
@gastaldi gastaldi merged commit 7f5cfdf into quarkusio:master Sep 18, 2020
@gsmet gsmet changed the title Update SmallRye Config to 1.9.0. Update SmallRye Config to 1.9.0 Sep 18, 2020
@radcortez radcortez deleted the config branch January 4, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants