Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs module - warning: instance variable @offset/@italic_angle not initialized #394

Closed
rsvoboda opened this issue Dec 27, 2018 · 3 comments
Labels
kind/enhancement New feature or request
Milestone

Comments

@rsvoboda
Copy link
Member

docs module - warning: instance variable @offset/@italic_angle not initialized

Warnings example

[INFO] Rendered /Users/rsvoboda/git/protean-shamrock/docs/src/main/asciidoc/application-configuration-guide.adoc
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/ttfunk-1.5.1/lib/ttfunk/table.rb:26: warning: instance variable @offset not initialized
uri:classloader:/gems/prawn-2.2.2/lib/prawn/font/ttf.rb:118: warning: instance variable @italic_angle not initialized

ttfunk is fixed via prawnpdf/ttfunk@086b312 from 6 May 2017. Last ttfunk release was April 2017. Found via prawnpdf/ttfunk#61

prawn is fixed via my PR prawnpdf/prawn#1095. Last prawn release was Mar 2017

I patched asciidoctorj-pdf-1.5.0-alpha.16.jar locally with the above fixes, no differences found in generated PDF files via patched vs. unpatched jar.

@cescoffier
Copy link
Member

Unfortunately, there is no version of asciidoctorj available from Maven central containing the fix.

I'm actually not sure that we need the PDF generation. So far we don't use these PDFs.

@gsmet
Copy link
Member

gsmet commented Dec 27, 2018

+1 to remove the PDF generation for now. We can easily enable it again if we want to do it later.

And hopefully, Rostislav's fixes will be included by then in a release.

@cescoffier
Copy link
Member

I just merged #395 fixing the issue by removing the PDF generation.

@cescoffier cescoffier added this to the 0.4.0 milestone Dec 28, 2018
@cescoffier cescoffier added the kind/enhancement New feature or request label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants