Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement signing and verifying for eddsa-ed25519-sha256 #16

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

poolpOrg
Copy link

The following PR implements eddsa-ed25519-sha256 signing and verifying

@jbowes
Copy link
Owner

jbowes commented Jun 14, 2023

Thanks for the PR!

Is ed25519 in use somewhere with sha256? I see that ed25519 was added to the spec, but with no hash function pre-applied.

Would you be interested in updating the PR to match the spec? or alternatively, point me at uses of the algos as used in the pr?

@poolpOrg
Copy link
Author

hello, sorry for the delay in my answer.

Is ed25519 in use somewhere with sha256? I see that ed25519 was added to the spec, but with no hash function pre-applied.

Indeed, you are right

Would you be interested in updating the PR to match the spec? or alternatively, point me at uses of the algos as used in the pr?

Sure, I will have a look at it this week, cheers

@poolpOrg
Copy link
Author

I'm very sorry, I got carried away at work + holidays, I had a look but didn't move forward.

I'll be working back at it in a week as I have a use-case at work pop-up again and might as well contribute upstream :-)

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants