Add a public signer/verifier interface for some common scenarios. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current transport/middleware design works well with native Go HTTP libraries. However, if I want to use some modern HTTP libraries like gin-gonic or resty, the user experience becomes a disaster. I have to clone
*http.Requestover and over and do a lot of dirty magic to prevent the middleware from corrupting my*gin.Context.Thus I propose this Verifier/Signer interface, which gives more control for us to plug-in them to other HTTP frameworks.
Moreover, if I'm maintaining tens of thousands of crypto keys, it's impossible to pass them one by one when initializing a verifier. Thus I propose a
VerifyingKeyResolverinterface, so that the verifier can search a database by itself.