Skip to content

Commit

Permalink
Fix goldenfile ouput (kubernetes-retired#2366)
Browse files Browse the repository at this point in the history
* Fix update-golde-files target

* Ensure golden file -update flag is defined during CI
  • Loading branch information
carolynvs authored and Jay Boyd committed Oct 31, 2018
1 parent 0d08801 commit a2d69c3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ verify: .init verify-generated verify-client-gen verify-docs verify-vendor
@$(DOCKER_CMD) build/verify-errexit.sh
@echo Running tag verification:
@$(DOCKER_CMD) build/verify-tags.sh
@echo Validating golden file flag is defined:
@$(DOCKER_CMD) go test -run DRYRUN ./cmd/svcat/... -update || printf "\n\nmake test-update-goldenfiles is broken. For each failed package above, add the following empty import to one of the test files to define the -update flag:\n_ \"github.com/kubernetes-incubator/service-catalog/internal/test\""

verify-docs: .init
@echo Running href checker$(SKIP_COMMENT):
Expand Down
2 changes: 2 additions & 0 deletions cmd/svcat/class/get_cmd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import (
"k8s.io/apimachinery/pkg/runtime"
k8sfake "k8s.io/client-go/kubernetes/fake"
k8stesting "k8s.io/client-go/testing"

_ "github.com/kubernetes-incubator/service-catalog/internal/test"
)

func TestListClasses(t *testing.T) {
Expand Down
2 changes: 2 additions & 0 deletions cmd/svcat/plan/get_cmd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import (
"k8s.io/apimachinery/pkg/runtime"
k8sfake "k8s.io/client-go/kubernetes/fake"
k8stesting "k8s.io/client-go/testing"

_ "github.com/kubernetes-incubator/service-catalog/internal/test"
)

func TestListPlans(t *testing.T) {
Expand Down

0 comments on commit a2d69c3

Please sign in to comment.