Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks/resolving ef issue #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WillStrohl
Copy link
Contributor

No description provided.

Copy link

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @hismightiness - it will be nice to use this project again!

@@ -139,7 +144,7 @@
</runtimePolicies>
</glimpse>
</node>
<node path="/configuration/glimpse" action="update" targetpath="/configuration/glimpse/tabs" collision="ignore">
<node path="/configuration/glimpse" action="update" targetpath="/configuration/glimpse/tabs" collision="overwrite">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to overwrite?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you reinstall, it adds it a second time, crashing the site.

@bdukes
Copy link
Collaborator

bdukes commented Aug 12, 2020

Have you tested that this doesn't cause an issue with sites that aren't using EF at all? Or site's using EF5?

@bdukes
Copy link
Collaborator

bdukes commented Aug 12, 2020

From what I recall of how these worked, I think the answer that's most compatible is just removing Glimpse.Ado.dll from the package.

@WillStrohl
Copy link
Contributor Author

The Ado DLL is using EF5, causing the site to crash. You have to explicitly add the EF6 DLL to prevent this.

https://stackoverflow.com/questions/21776705/unable-to-cast-object-of-type-glimpse-ado-alternatetype-glimpsedbconnection-to

Glimpse/Glimpse#737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants