Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: various tweaks #1

Merged
merged 1 commit into from
Oct 16, 2023
Merged

tree: various tweaks #1

merged 1 commit into from
Oct 16, 2023

Commits on Oct 14, 2023

  1. tree: various tweaks

    These are tweaks we worked on together to get iSCSI booting working.
    
    I didn't reflect the changes back in the main README. Will let you do
    that. :)
    
    For posterity, notes on some of the things we changed:
    - delete `saveconfig.json`; we recreate the config imperatively from
      scratch each time for more clarity
    - put `targetcli_script` in `/usr/local/bin`; we can't write files
      directly in `/`
    - drop the virtiofs mount unit; we rely on cosa to do that (this assumes
      then that we're running this from a cosa workdir, likely we'll want to
      make this more generic in the future)
    - order against `target.service`, not `target.container`; the latter is
      just an input file to the quadlet generator and is foreign to systemd
    - add `ConditionFirstBoot=true` since we only need to set up the iSCSI
      target on first boot
    - move `network-online.target` ordering to `[Unit]` section
    - make all the `targetcli` commands run in the same `podman exec`
      invocation
    - cargo-cult a bunch more ACL-related targetcli settings
    jlebon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    6faf922 View commit details
    Browse the repository at this point in the history