Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch docs build to mamba #76

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Switch docs build to mamba #76

merged 2 commits into from
Jan 13, 2022

Conversation

jbusecke
Copy link
Owner

@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #76 (55b6664) into master (3e00813) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files           3        3           
  Lines         324      324           
  Branches       59       59           
=======================================
  Hits          258      258           
  Misses         43       43           
  Partials       23       23
Flag Coverage Δ
unittests 79.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e00813...55b6664. Read the comment docs.

@jbusecke
Copy link
Owner Author

Ughhh this is not building a preview again. @zmoon do you have an opinion on this? Should I just merge this and see?

zmoon
zmoon reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@zmoon zmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, hadn't realized mamba was officially supported now

.readthedocs.yaml Outdated
Comment on lines 6 to 8
sphinx:
configuration: docs/conf.py
fail_on_warning: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could keep this part?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

.readthedocs.yaml Outdated
Comment on lines 8 to 11
python:
install:
- method: setuptools
path: .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed, since environment-docs.yml already specifies installing xmovie.

@zmoon
Copy link
Contributor

zmoon commented Jan 12, 2022

Ughhh this is not building a preview again. @zmoon do you have an opinion on this? Should I just merge this and see?

I think it is worth a try! I think my approach in #73 might help even more, since I trimmed the RTD deps to only those needed to actually build the docs. But #73 is still pending your review and some more work.

@jbusecke jbusecke merged commit f27d4e0 into master Jan 13, 2022
@zmoon
Copy link
Contributor

zmoon commented Jan 13, 2022

It didn't fail! 🥳

@jbusecke
Copy link
Owner Author

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoon zmoon zmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs build failing
2 participants
@jbusecke @zmoon