Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iframe overlay in dev #1195

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Fix iframe overlay in dev #1195

merged 3 commits into from
Jun 10, 2022

Conversation

aeolianeth
Copy link
Contributor

What does this PR do and why?

Acceptance checklist

@aeolianeth aeolianeth added Bug Not functioning as expected. housekeeping labels Jun 10, 2022
@aeolianeth aeolianeth self-assigned this Jun 10, 2022
resolved "https://registry.yarnpkg.com/react-error-overlay/-/react-error-overlay-6.0.11.tgz#92835de5841c5cf08ba00ddd2d677b6d17ff9adb"
integrity sha512-/6UZ2qgEyH2aqzYZgQPxEnz33NJ2gNsnHA2o5+o4wW9bLM/JYQitNP9xPhsXwC08hMMovfGe/8retsdDsczPRg==
react-error-overlay@6.0.9, react-error-overlay@^6.0.9:
version "6.0.9"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the fix for the overlay

@aeolianeth
Copy link
Contributor Author

@johnnyd-eth could you please review

Copy link
Contributor

@johnnyd-eth johnnyd-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. LGTM

@johnnyd-eth johnnyd-eth merged commit 9828e9a into main Jun 10, 2022
tomquirk pushed a commit that referenced this pull request Feb 11, 2023
* Fix iframe overlay in dev

* Bump antd v4.21.0

Co-authored-by: Johnny D <johnnyD.eth@protonmail.com>
tomquirk added a commit that referenced this pull request Feb 11, 2023
* Fix iframe overlay in dev

* Bump antd v4.21.0

Co-authored-by: Johnny D <johnnyD.eth@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Not functioning as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this the bug of react-error-overlay?
3 participants