Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for (pytho3.8&&django.3.2), add support for (python3.11,3.12&&django5.0,django5.1) #191

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

TGoddessana
Copy link
Collaborator

@TGoddessana TGoddessana commented Sep 19, 2024

  1. removed the outdated python version from github actions and modified it to test against the latest django version.

  2. removed pytest-pythonpath, which seems to be no longer maintained, and bumped the version to pytest>7, which supports specifying pythonpath.

  3. added tox settings.

My concern is the rules for releasing new versions - I don't know what versioning policy this package is following, but would it be okay to add this as a new 0.7.0 version?

In order to add a new version, is there a set of actions that the community needs to take, such as making changes to the API, dropping methods, deciding to add new features at the expense of backwards compatibility, etc., although ultimately it is the maintainer's role.

@TGoddessana TGoddessana self-assigned this Sep 20, 2024
@TGoddessana TGoddessana merged commit d1e2261 into jcass77:develop Sep 23, 2024
5 checks passed
@jcass77
Copy link
Owner

jcass77 commented Sep 25, 2024

I think a bump to v0.7.0 is fine. The loose convention has been that 0.x.0 is for new features and 0.0.x for bug fixes.

@TGoddessana
Copy link
Collaborator Author

thanks :)

remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: 
remote: - Changes must be made through a pull request.
To https://github.com/jcass77/django-apscheduler.git
 * [new tag]         v0.7.0 -> v0.7.0
 ! [remote rejected] main -> main (protected branch hook declined)

while i trying to publish a new release, this error occured in step 5.

i tried the same steps with my forked repository, but i couldn't checkout to branch main, which is step 3.

If the changes are okay, I'd like to publish a release v0.7.0 :)

@jcass77
Copy link
Owner

jcass77 commented Sep 28, 2024

I'm not sure why the release procedures would fail for you - the permissions are supposed to be the same for all collaborators - are you sure you pushed your changes to the 'develop' branch first?

At any rate, I have gone ahead and cut release v0.7.0.

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants