Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone support when rendering datetimes #43

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Add timezone support when rendering datetimes #43

merged 2 commits into from
Nov 19, 2018

Conversation

jcass77
Copy link
Owner

@jcass77 jcass77 commented Nov 17, 2018

Provides timezone support that is aligned with standard Django.

  • introduces APSCHEDULER_DATETIME_FORMAT which can be used to configure the time format that should be used. The default just adds seconds to Django's default DATETIME_FORMAT setting.
  • timestamps will be rendered in the local time if timezone support is enabled via USE_TZ = True.
  • unit tests for all changes made.

@codecov-io
Copy link

Codecov Report

Merging #43 into master will increase coverage by 0.4%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #43     +/-   ##
=========================================
+ Coverage   72.29%   72.69%   +0.4%     
=========================================
  Files           9        9             
  Lines         296      304      +8     
=========================================
+ Hits          214      221      +7     
- Misses         82       83      +1
Impacted Files Coverage Δ
django_apscheduler/admin.py 0% <0%> (ø) ⬆️
django_apscheduler/util.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555fa7d...86b7234. Read the comment docs.

@jcass77
Copy link
Owner Author

jcass77 commented Nov 17, 2018

The travis build appears to be failing for Django 1.8, and I could not find a trivial solution for making this PR backwards compatible.

Extended support for version 1.8 of Django ended on April 1, 2018 - do we really still need to support it?

I have taken the liberty of pushing 86b7234, which drops support for legacy versions of Django.

@jarekwg jarekwg merged commit 8374ca6 into jcass77:master Nov 19, 2018
@jarekwg
Copy link
Collaborator

jarekwg commented Nov 19, 2018

Thanks!

@jcass77 jcass77 deleted the enh/timezone_support branch October 6, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants