Drop netty-tcnative as a dependency under Java 8 and newer #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchambers
force-pushed
the
drop_tcnative
branch
4 times, most recently
from
b0a7666
to
666b337
Compare
jchambers
force-pushed
the
drop_tcnative
branch
from
666b337
to
a2d2d05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved to direct protocol negotiation in #598, we no longer strictly need
netty-tcnativeunder Java 8 and newer. This change makes that A Thing™. After this, folks who want to usenetty-tcnativewill need to add it as a dependency on their own.I suspect this will provoke some opinions; what do you all think?