Skip to content

Commit

Permalink
change default master-worker config to true
Browse files Browse the repository at this point in the history
Master worker mode has a better process handling, more config key
options, and should be the option if the user doesn't have a reason to
choose the standalone daemon.
  • Loading branch information
jcmoraisjr committed Jun 7, 2024
1 parent 660edd4 commit 5af547a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions docs/content/en/docs/configuration/command-line.md
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,10 @@ Since v0.14

Defines if haproxy should be configured in master-worker mode. If `false`, one single process
is forked in the background. If `true`, a master process is started in the foreground and can
be used to manage current and old worker processes. The default value is `false`, which
preserves historical behavior of HAProxy Ingress. External HAProxy deployment needs
master-worker mode and will enforce `--master-worker` as `true` if configured.
be used to manage current and old worker processes. The default value is `false` in v0.14, which
preserves historical behavior of HAProxy Ingress. v0.15 and newer defaults to `true` if not
declared. External HAProxy deployment needs master-worker mode and will enforce
`--master-worker` as `true` if configured.

---

Expand Down
1 change: 1 addition & 0 deletions pkg/controller/config/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ func NewOptions() *Options {
IngressClass: "haproxy",
ReloadStrategy: "reusesocket",
WatchGateway: true,
MasterWorker: true,
AcmeCheckPeriod: 24 * time.Hour,
AcmeFailInitialDuration: 5 * time.Minute,
AcmeFailMaxDuration: 8 * time.Hour,
Expand Down

0 comments on commit 5af547a

Please sign in to comment.