Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/cookie names when dynamic scaling is off #502

Closed
brianloss opened this issue Jan 16, 2020 · 5 comments
Closed

server/cookie names when dynamic scaling is off #502

brianloss opened this issue Jan 16, 2020 · 5 comments

Comments

@brianloss
Copy link
Contributor

I finally got around to checking out v0.8, and I noticed that when dynamic scaling is off, the server name is still a name such as "srv001". In prior versions, the server name was the pod name. It is critical for my use case that the server name be the pod name (really it's the cookie name that's critical, but having the server name match helps with monitoring/debugging). We rely on this in order to provide direct access to servers for testing and debugging issues.

Is there any way to make this behave like it did before so that when dynamic scaling is off (and ingress.kubernetes.io/session-cookie-dynamic is set to false), the generated server and cookie name match the pod name?

@jcmoraisjr
Copy link
Owner

Hi, this was slightly discussed on #469 . I'm finishing some metric docs right now and I'll have the time to new improvements shortly - this has some priority to me since it's a small regression.

@brianloss
Copy link
Contributor Author

That would be great, thanks! Sorry about the duplicate ticket.

@jcmoraisjr
Copy link
Owner

Please have a look at #507 and say how it sounds. I'm fine to patch up to v0.8 since it's a regression and doesn't touch any internals.

@brianloss
Copy link
Contributor Author

Sorry for the delayed response—I’ve been out on holiday. This looks good, and would be very useful to us to have in v0.8. Thanks!

@jcmoraisjr
Copy link
Owner

Hi, added backend-server-naming which can be used globally or per ingress object as an annotation. Merged up to v0.8.1. Docs here. Closing, let me know if you have any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants