add backend-server-naming key #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks for the quick turn around! |
This fixes a small regression since v0.8: when dynamic scaling is disabled, backend servers were named with target's ip/port which give some context to logs. The behaviour is slightly different now: default value is sequence despite the dynamic update config, the admin/dev can change it using svc/ing annotation or globally using configmap.
jcmoraisjr
force-pushed
the
jm-server-naming
branch
from
d311cd6 to
9957833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small regression since v0.8: when dynamic scaling is disabled, backend servers were named with target's ip/port which give some context to logs. The behaviour is slightly different now: default value is sequence despite the dynamic update config, the admin/dev can change it using svc/ing annotation or globally using configmap.