Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes configmap based tcp sync #1001

Merged
merged 1 commit into from
May 28, 2023
Merged

Fixes configmap based tcp sync #1001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/converters/converters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ func (c *converters) Sync() {
//
// configmap converters
//
if changed.TCPConfigMapDataCur != nil {
if changed.TCPConfigMapDataCur != nil || changed.TCPConfigMapDataNew != nil {
// We always need to run configmap based tcp sync, when configured, because
// we don't have any tracking in place asking us to do it on, e.g., endpoint
// or secret updates. Although cur is always assigned if configmap based tcp
// is configured, only new is assigned in the very first run. Otoh new is
// only assigned when the configmap is changed. So we need to check both.
tcpSvcConverter := configmap.NewTCPServicesConverter(c.options, c.haproxy, changed)
tcpSvcConverter.Sync()
c.timer.Tick("parse_tcp_svc")
Expand Down