Improve old and new backend comparison #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old and new backends are compared whenever a direct or indirect related ingress, service or endpoint changes. This comparison improves CPU usage avoiding cfg bulding if configurations match, and haproxy reload if a dynamic update can be made. A static comparison check if all but endpoints match. This comparison need to ignore internal controller attributes related with endpoint, otherwise any change eg to the endpoints order would count as a backend change, which is not right. `pathConfig` was added in Per Path Backend Config and since then it was incorrectly firing some backend cfg parsings. This commit remove it from the comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old and new backends are compared whenever a direct or indirect related ingress, service or endpoint changes. This comparison improves CPU usage avoiding cfg bulding if configurations match, and haproxy reload if a dynamic update can be made.
A static comparison check if all but endpoints match. This comparison need to ignore internal controller attributes related with endpoint, otherwise any change eg to the endpoints order would count as a backend change, which is not right.
pathConfigwas added in Per Path Backend Config and since then it was incorrectly firing some backend cfg parsings. This commit remove it from the comparison.