Add --sort-endpoints-by command-line option #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a few more options on how to sort endpoints of a backend. Currently `--sort-backends` switches between the same k8s endpoints order and naming order - which only makes sense if `backend-server-naming` was changed. `--sort-endpoints-by` also brings back the old behavior (v0.7 and older) of missing `--sort-backends`: `random` option will shuffle endpoints of all backends whenever a haproxy reload is fired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few more options on how to sort endpoints of a backend. Currently
--sort-backendsswitches between the same k8s endpoints order and naming order - which only makes sense ifbackend-server-namingwas changed.--sort-endpoints-byalso brings back the old behavior (v0.7 and older) of missing--sort-backends:randomoption will shuffle endpoints of all backends whenever a haproxy reload is fired.