Allow signer to work with wildcard dns certs #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution and also for the provided test! I just realized that the current test can be extended to explore the wildcard scenario, what about add these new testcases in the array? You can use a distinct secret/crt changing the input accordingly and adding the new one in the cache mock. |
|
You are right! Changes just commited. |
|
Finally travis released this, lgtm, thanks! Merging. |
|
ok, so when new version with docker image will be released? :) |
|
v0.11 before the weekend, v0.10 and hope v0.12 next week, v0.9 this year. |
|
gr8! waiting ;] |
jcmoraisjr
pushed a commit
that referenced
this pull request
Nov 5, 2020
jcmoraisjr
pushed a commit
that referenced
this pull request
Nov 5, 2020
jcmoraisjr
pushed a commit
that referenced
this pull request
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in topic, this pr allows acme signer to work with wildcard dns in cert.
Instead of #693