Independently configure rules and TLS #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the very first controller version, the TLS spec was only configured if a corresponding hostname was found in the rules of the same ingress resource. This commit changes this behavior and reads the TLS array as an independent configuration. Such update changes backward compatibility since a misconfigured TLS would be silently ignored. However the new behavior better implements the ingress spec.
|
Hi, Thank you so much for picking this up! I have a question though. Would it be possible to include annotation processing as well when only TLS is configured? Technically a decent part of the annotations configure TLS behavior. This would remove sooo much complexity for us. |
Yup, this is exactly how it should work - no matter where you configured a hostname, either in rules or just in tls, they should be added to the configuration in the same way. |
|
Ah sorry I missed the part where you added that line. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the very first controller version, the TLS spec was only configured if a corresponding hostname was found in the rules of the same ingress resource. This commit changes this behavior and reads the TLS array as an independent configuration.
Such update changes backward compatibility since a misconfigured TLS would be silently ignored. However the new behavior better implements the ingress spec.