Add sni and verifyhost to secure connections #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add options to securely connect over untrusted networks and avoid man in the middle attack. Without these options only date and the certificate authority that issued the server certificate can be verified. SNI static or dynamically configures the SNI TLS extension to the backend server, and also verifies the name of the server certificate if a ca bundle is provided. Verifyhost does the same without changing the SNI extension and only accepts a static hostname.
jcmoraisjr
force-pushed
the
jm-ssl-verify
branch
from
6cdf54d to
e1e1d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options to securely connect over untrusted networks and avoid man in the middle attack. Without these options only date and the certificate authority that issued the server certificate can be verified. SNI static or dynamically configures the SNI TLS extension to the backend server, and also verifies the name of the server certificate if a ca bundle is provided. Verifyhost does the same without changing the SNI extension and only accepts a static hostname.
Should be merged as far as v0.11 due to security reasons.