Fix initial weight configuration #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weights can be used to distribute distinct load to distinct servers in the same backend. An initial value greater the default 1 (one) can be configured so agents that changes server weight can properly work and adjust the weight in lower granularity. The initial weight configuration isn't properly working when declared in the ingress resource because its usage occurs before the value is actually read from the ingress annotation. It works however when declared in the service - service has priority and is read in the same block the backend is created and configured with initial weight and other defaults. Moving down the reading just before starting the endpoint configuration fixes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weights can be used to distribute distinct load to distinct servers in the same backend. An initial value greater the default 1 (one) can be configured so agents that changes server weight can properly work and adjust the weight in lower granularity.
The initial weight configuration isn't properly working when declared in the ingress resource because its usage occurs before the value is actually read from the ingress annotation. It works however when declared in the service - service has priority and is read in the same block the backend is created and configured with initial weight and other defaults. Moving down the reading just before starting the endpoint configuration fixes this.