Improve crt validation with ssl_c_verify #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAProxy Ingress validates client certificates using ACL in order to give a http response. The samples used were `ssl_c_ca_err` that returns >0 if there is a problem in the ca bundle (depth>0), and `ssl_c_err` that returns >0 if there is a problem in the certificate itself. However, there were observed outdated client certificates that doesn't trigger a failure in `ssl_c_err` but it does in `ssl_c_verify` which also check against the CA bundle and motivated this update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAProxy Ingress validates client certificates using ACL in order to give a http response. The samples used were
ssl_c_ca_errthat returns >0 if there is a problem in the ca bundle (depth>0), andssl_c_errthat returns >0 if there is a problem in the certificate itself. However, there were observed outdated client certificates that doesn't trigger a failure inssl_c_errbut it does inssl_c_verifywhich also check against the CA bundle and motivated this update.