Fix incorrect reload if endpoint list grows #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic updates need to check the size of the endpoint list size. Up to now the backend server list cannot dynamically grow, even when using DNS updates. HAProxy Ingress has a list of empty slots to dynamically update endpoints, forcing a reload only when no new empty slots can be found. Kubernetes' ep based updates always rebalance new endpoints with empty slots so its size is at least as big as the old one, but DNS based only do this if a reload is needed. This update rebalance the new list, so future DNS based dynamic updates can work without needing to reload haproxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic updates need to check the size of the endpoint list size. Up to now the backend server list cannot dynamically grow, even when using DNS updates. HAProxy Ingress has a list of empty slots to dynamically update endpoints, forcing a reload only when no new empty slots can be found.
Kubernetes' ep based updates always rebalance new endpoints with empty slots so its size is at least as big as the old one, but DNS based only do this if a reload is needed. This update rebalance the new list, so future DNS based dynamic updates can work without needing to reload haproxy.