Fix default host if configured as ssl-passthrough #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL passthrough domains are added in the same hostname maps used to route http requests. They share most of their configurations with a few exceptions. One of these exceptions weren't properly implemented - default host was always being configured in the http proxy. This update checks if the default host is an ssl passthrough, properly configuring it in the tcp proxy instead.
jcmoraisjr
force-pushed
the
jm-defaulthost-passthrough
branch
from
bb012af to
ef4937b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL passthrough domains are added in the same hostname maps used to route http requests. They share most of their configurations with a few exceptions. One of these exceptions weren't properly implemented - default host was always being configured in the http proxy. This update checks if the default host is an ssl passthrough, properly configuring it in the tcp proxy instead.