Fix reading of tls secret without crt or key #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrets with a CA bundle or crt+key pair uses the same internal struct to represent them. Distinct functions verify if the proper fields are filled to determine if the secret is correctly configured. The crt+key reading however is checking a common field used by CA and crt secrets, leading to a nil dereference when a certificate isn't properly configured. This update ensures that a certificate is properly configured. Thanks Maurilio for finding this. Should be merged as far as v0.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secrets with a CA bundle or crt+key pair uses the same internal struct to represent them. Distinct functions verify if the proper fields are filled to determine if the secret is correctly configured. The crt+key reading however is checking a common field used by CA and crt secrets, leading to a nil dereference when a certificate isn't properly configured. This update ensures that a certificate is properly configured. Thanks Maurilio for finding this.
Should be merged as far as v0.10.