Fix auth-url parsing if hostname misses a dot #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`auth-url` accepts http/s or service protocol, and the later accepts namespaced service names, if the configuration allows, since `v0.13-snapshot.3`. Namespaced names has a slash just like URIs, so parsing the whole URL is somewhat tricky. A domain name without dots was being matched as a namespace and concatenated with the first dir of the path, leading to a lookup error. This update fixes this behavior and also adds a few more unit tests covering more URL formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auth-urlaccepts http/s or service protocol, and the later accepts namespaced service names, if the configuration allows, sincev0.13-snapshot.3. Namespaced names has a slash just like URIs, so parsing the whole URL is somewhat tricky. A domain name without dots was being matched as a namespace and concatenated with the first dir of the path, leading to a lookup error. This update fixes this behavior and also adds a few more unit tests covering more URL formats.