Always deny requests of failed auth configurations #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attempt to configure auth external or oauth means that the backend should be protected. However the current implementation is leaving the backend unprotected if a misconfiguration is found - which can be an external failure like a dns lookup. This update ensures that an attempt to protect a backend will in fact protect it, and misconfigurations or failures during the configuration parsing means an always-deny behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attempt to configure auth external or oauth means that the backend should be protected. However the current implementation is leaving the backend unprotected if a misconfiguration is found - which can be an external failure like a dns lookup. This update ensures that an attempt to protect a backend will in fact protect it, and misconfigurations or failures during the configuration parsing means an always-deny behavior.