Option to use client and master socket in keep alive mode #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the haproxy/utils package is dedicated to utilities related with client or master socket and to convert its response to a structured object. The package is being renamed to better reflect its purpose, which will also be even more specialized with connections in interactive mode.
Change from the open/send/close sequence when communicating with client and master sockets to always leave the connection open. This improves the communication speed, and also makes the first step on behalf of retrieve data from stopping instances whose listening sockets aren't alive anymore.
jcmoraisjr
changed the title
Add the ability to disable keep alive (prompt mode, interactive) when creating HAProxySocket. This will be the default to the current/living instance - if for any reason HAProxy is restart outside the controller, the established connection with the old instance would be used to send dynamic updates. This can be improved in the future. The same connection is still being used if more than one command is sent at the same time, which happens when enabling and disabling backend servers.
jcmoraisjr
force-pushed
the
jm-cli-keep-alive
branch
from
c761381 to
ecfa5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to change from the open/send/close sequence when communicating with client and master sockets to always leave the connection open, or reuse the same connection whenever more than one command should be sent. This improves the communication speed, and also makes the first step on behalf of retrieve data from stopping instances whose listening sockets aren't alive anymore.