Fix dynamic update of frontend crt #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v0.13 certificates can be dynamically updated, however a reload was always scheduled due to an indirect reference from the backend to the frontend's certificate hash. This hash is used to the backend know if the frontend has a TLS certificate. When the certificate is changed, the hash is changed as well, leading to a configuration change that triggers a reload. The reference was moved to the filename, which can also be used to check TLS enabled and cannot be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v0.13 certificates can be dynamically updated, however a reload was always scheduled due to an indirect reference from the backend to the frontend's certificate hash. This hash is used to the backend know if the frontend has a TLS certificate. When the certificate is changed, the hash is changed as well, leading to a configuration change that triggers a reload. The reference was moved to the filename, which can also be used to check TLS enabled and cannot be changed.