Fix endpoint update of configmap based tcp services #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy ConfigMap based TCP services has its own endpoint list that doesn't track partial parsing. The entry point was changed when Gateway API was added, it was was incorrectly configured to only run when a full sync is needed, or when the ConfigMap was changed, leading to new state not being reflected in the configuration. This update ensures that ConfigMap based TCP services is always parsed when something changes in the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy ConfigMap based TCP services has its own endpoint list that doesn't track partial parsing. The entry point was changed when Gateway API was added, it was was incorrectly configured to only run when a full sync is needed, or when the ConfigMap was changed, leading to new state not being reflected in the configuration. This update ensures that ConfigMap based TCP services is always parsed when something changes in the cluster.