Fix ingress update to an existing backend #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resource tracking is used to identify resources that should be parsed due to a configuration change. Resources directly or indirectly related with what was changed is removed and recreated to ensure that old behavior doesn't survive in the new state. A new ingress is already tracked to ensure that the referenced hosts and backends are removed, but this wasn't happening with existent ingress that reference a new backend that was already referenced elsewhere - such hosts and backends was being properly tracked for future updates, but would be missing some new configurations provided by the ingress that started to reference them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource tracking is used to identify resources that should be parsed due to a configuration change. Resources directly or indirectly related with what was changed is removed and recreated to ensure that old behavior doesn't survive in the new state. A new ingress is already tracked to ensure that the referenced hosts and backends are removed, but this wasn't happening with existent ingress that reference a new backend that was already referenced elsewhere - such hosts and backends was being properly tracked for future updates, but would be missing some new configurations provided by the ingress that started to reference them.