Fix error message on secret/cm update failure #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acme functionality needs permission to create or update secrets when a new certificate is issued, and also to save the client's private key. This permission isn't added in the default configuration. The func that creates or updates the secret should return an error if anything went wrong, but the variable that has the error instance was being redeclared inside the if block, and was always returning nil even if an error (eg missing permission) occur. The same is happening with ConfigMap, which is used to save the challenge token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acme functionality needs permission to create or update secrets when a new certificate is issued, and also to save the client's private key. This permission isn't added in the default configuration. The func that creates or updates the secret should return an error if anything went wrong, but the variable that has the error instance was being redeclared inside the if block, and was always returning nil even if an error (eg missing permission) occur.
The same is happening with ConfigMap, which is used to save the challenge token.