Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #874

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Bump dependencies #874

merged 1 commit into from
Feb 4, 2022

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Dec 26, 2021

This change bumps golang to 1.16.12 and updates dependencies in go.mod.

@jcmoraisjr
Copy link
Owner

Great, thank you! We should have a v0.14 tag in a month or so, I'll leave this open so we can merge an up to date client-go and golang versions.

@mrueg
Copy link
Contributor Author

mrueg commented Dec 27, 2021

Great, thank you! We should have a v0.14 tag in a month or so, I'll leave this open so we can merge an up to date client-go and golang versions.

Do you want me to upgrade to go 1.17 and k8s 1.23?

@jcmoraisjr
Copy link
Owner

Both golang and Kubernetes releases have a faster step if compared with haproxy ingress, so yes go 1.17 and k8s 1.23 seems to be a more reasonable options.

@jcmoraisjr
Copy link
Owner

Hi, we're really late with v0.14 and maybe we'll issue the first tag in the next few days. Please confirm if you can squash all the commits into a single one and rebase on top of master, I'll merge it just after that. Btw thanks for maintaining this branch up to date.

@mrueg
Copy link
Contributor Author

mrueg commented Feb 4, 2022

@jcmoraisjr working on fixing conflicts and squashing

@mrueg mrueg force-pushed the bump-dependencies branch from 2abb867 to ace0ca4 Compare February 4, 2022 11:13
@jcmoraisjr
Copy link
Owner

My local env suggested me to move gopkg.in/go-playground/assert.v1 to the second require argument, can you confirm this?

@mrueg mrueg force-pushed the bump-dependencies branch from ace0ca4 to 240a3ec Compare February 4, 2022 12:33
@mrueg
Copy link
Contributor Author

mrueg commented Feb 4, 2022

My local env suggested me to move gopkg.in/go-playground/assert.v1 to the second require argument, can you confirm this?

Yes, you're correct. I fixed it! Thanks for catching that :)

@jcmoraisjr
Copy link
Owner

LGTM, thanks! Merging now.

@jcmoraisjr jcmoraisjr merged commit 571510e into jcmoraisjr:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants