Add disableKeywords only if defined #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--disable-config-keywords` command-line option allows to define a comma separated list of blacklisted keywords. If not declared, an empty string is used as an input to `Split()`. This empty string is however converted in an array of one element with an empty string, and such empty keyword matches with empty lines, denying configurations with empty lines. This update ignores empty entries when parsing the custom snippet, and also `TrimSpace()` all the options in order to properly match with the custom snippet tokenizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--disable-config-keywordscommand-line option allows to define a comma separated list of blacklisted keywords. If not declared, an empty string is used as an input toSplit(). This empty string is however converted in an array of one element with an empty string, and such empty keyword matches with empty lines, denying configurations with empty lines. This update ignores empty entries when parsing the custom snippet, and alsoTrimSpace()all the options in order to properly match with the custom snippet tokenizer.