Fix sni sample fetch on ssl decyphered tcp conns #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotation based TCP Services has the ability to choose a TCP backend based on the TLS SNI extension sent by the client. HAProxy however has two distinct samples fetches for read the SNI extension, one used in pure TCP connections and the help of the inspect-delay, another one used on requests decyphered by haproxy. This distinction wasn't being made by the controller. Should be merged to v0.13.
This is a cosmectic change: ingress updater is the responsible to reflect the backend mode based on how the frontend was configured, this is just replicating the behavior to the final configuration seems ... correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotation based TCP Services has the ability to choose a TCP backend based on the TLS SNI extension sent by the client. HAProxy however has two distinct samples fetches for read the SNI extension, one used in pure TCP connections and the help of the inspect-delay, another one used on requests decyphered by haproxy. This distinction wasn't being made by the controller.
Should be merged to v0.13.