Fix match of prefix pathtype if using default host #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAProxy's subdir match type is used to implement the `Prefix` pathType. This match type however doesn't implement exactly what is expected from the `Prefix` type if a single slash is used as the pattern - ingress expects that `/bar` would match, but it doesn't, matching only `/bar/` instead. This works well with declared hostnames because HAProxy Ingress builds the pattern concatenating hostname and path, but this doesn't happen with the default hostname where the path is configured alone. This update adds a prefix in the default hostname patterns, just like it's already happening with declared hostnames, in order to them to behave in the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAProxy's subdir match type is used to implement the
PrefixpathType. This match type however doesn't implement exactly what is expected from thePrefixtype if a single slash is used as the pattern - ingress expects that/barwould match, but it doesn't, matching only/bar/instead. This works well with declared hostnames because HAProxy Ingress builds the pattern concatenating hostname and path, but this doesn't happen with the default hostname where the path is configured alone.This update adds a prefix in the default hostname patterns, just like it's already happening with declared hostnames, in order to them to behave in the same way.