Remove readiness endpoint from starting config #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External HAProxy starts with a bare minimum configuration, just to serve as a placeholder to the first real configuration. We need this first configuration so we have a process to be reloaded remotely. This needs to be a bare minimum / invalid because in that stage we don't have information enough to create a real configuration. This starting configuration however might lead to a false positive ready state from the cluster perspective because of the /healthz endpoint implemented in the starting configuration. This endpoint is being removed from that stage, so the cluster can property mark the pod as not ready and remove from load balancers until the real configuration is in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External HAProxy starts with a bare minimum configuration, just to serve as a placeholder to the first real configuration. We need this first configuration so we have a process to be reloaded remotely. This needs to be a bare minimum / invalid because in that stage we don't have information enough to create a real configuration.
This starting configuration however might lead to a false positive ready state from the cluster perspective because of the /healthz endpoint implemented in the starting configuration. This endpoint is being removed from that stage, so the cluster can property mark the pod as not ready and remove from load balancers until the real configuration is in place.