Skip to content

Commit

Permalink
Update tests to use up to date versions of Go (#470)
Browse files Browse the repository at this point in the history
update Go version in tests
update gofmt of examples
fix goidentity imports in examples
workaround go modules being default as of 1.16 for v7 that does not use modules
  • Loading branch information
jcmturner authored Jun 13, 2022
1 parent 663478b commit b3564a0
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 7 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,14 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: [ '1.14.x', '1.15.x' ]
go: [ '1.16.x', '1.17.x', '1.18.x' ]
env:
TEST_KDC_ADDR: 127.0.0.1
TEST_HTTP_URL: http://cname.test.gokrb5
TEST_HTTP_ADDR: 127.0.0.1
DNS_IP: 127.0.88.53
DNSUTILS_OVERRIDE_NS: 127.0.88.53:53
GO111MODULE: auto
steps:
- name: Set up Go ${{ matrix.go }}
uses: actions/setup-go@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/testingv8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: [ '1.14.x', '1.15.x' ]
go: [ '1.16.x', '1.17.x', '1.18.x' ]
env:
TEST_KDC_ADDR: 127.0.0.1
TEST_HTTP_URL: http://cname.test.gokrb5
Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ Development will be focused on the latest major version. New features will only


#### Go Version Support
![Go version](https://img.shields.io/badge/Go-1.15-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.14-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.18-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.17-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.16-brightgreen.svg)

gokrb5 may work with other versions of Go but they are not formally tested.
It has been reported that gokrb5 also works with the [gollvm](https://go.googlesource.com/gollvm/) compiler but this is not formally tested.
Expand Down
2 changes: 2 additions & 0 deletions examples/example-AD.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand All @@ -11,6 +12,7 @@ import (
"net/http/httptest"
"os"

goidentity "gopkg.in/jcmturner/goidentity.v3"
"gopkg.in/jcmturner/gokrb5.v7/client"
"gopkg.in/jcmturner/gokrb5.v7/config"
"gopkg.in/jcmturner/gokrb5.v7/credentials"
Expand Down
3 changes: 2 additions & 1 deletion examples/example.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

// Package examples provides simple examples of gokrb5 use.
Expand All @@ -12,7 +13,7 @@ import (
"net/http/httptest"
"os"

"gopkg.in/jcmturner/goidentity.v3"
goidentity "gopkg.in/jcmturner/goidentity.v3"
"gopkg.in/jcmturner/gokrb5.v7/client"
"gopkg.in/jcmturner/gokrb5.v7/config"
"gopkg.in/jcmturner/gokrb5.v7/keytab"
Expand Down
1 change: 1 addition & 0 deletions examples/httpClient.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand Down
1 change: 1 addition & 0 deletions examples/httpServer.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand Down
5 changes: 3 additions & 2 deletions v8/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ Development will be focused on the latest major version. New features will only


#### Go Version Support
![Go version](https://img.shields.io/badge/Go-1.15-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.14-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.18-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.17-brightgreen.svg)
![Go version](https://img.shields.io/badge/Go-1.16-brightgreen.svg)

gokrb5 may work with other versions of Go but they are not formally tested.
It has been reported that gokrb5 also works with the [gollvm](https://go.googlesource.com/gollvm/) compiler but this is not formally tested.
Expand Down
1 change: 1 addition & 0 deletions v8/examples/example-AD.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand Down
1 change: 1 addition & 0 deletions v8/examples/example.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Package examples provides simple examples of gokrb5 use.
//go:build examples
// +build examples

package main
Expand Down
1 change: 1 addition & 0 deletions v8/examples/httpClient.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand Down
1 change: 1 addition & 0 deletions v8/examples/httpServer.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand Down
1 change: 1 addition & 0 deletions v8/examples/longRunningClient.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build examples
// +build examples

package main
Expand Down

0 comments on commit b3564a0

Please sign in to comment.