Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

feat: generate collision shapes from mesh via the PendingConvexCollision component (behind the collision-from-mesh feature flag) #190

Merged
merged 7 commits into from
Feb 19, 2022

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Feb 18, 2022

Simplifies spawning GLTF models with collision.

User spawns a GTLF model as usual and inserts PendingConvexCollision component. Then the system iterates over entities with this component and generates convex hull collision based on geometry. After generation, the component is removed.

Note: it requires access to render due to mesh manipulations.

@Shatur Shatur changed the title Implement convex collision generation for scenes feat!: implement convex collision generation for scenes Feb 18, 2022
@jcornaz jcornaz self-requested a review February 19, 2022 08:56
@jcornaz jcornaz self-assigned this Feb 19, 2022
@jcornaz jcornaz added the enhancement New feature or improvement label Feb 19, 2022
Copy link
Owner

@jcornaz jcornaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution :-)

I left a few inline comments. The most important IMO is to figure out if we can get rid of the real assets for the tests.

Thanks for your help ;-)

Cargo.toml Outdated Show resolved Hide resolved
core/src/lib.rs Outdated Show resolved Hide resolved
core/src/pending_collision.rs Outdated Show resolved Hide resolved
core/src/pending_collision.rs Outdated Show resolved Hide resolved
Copy link
Owner

@jcornaz jcornaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@jcornaz jcornaz changed the title feat!: implement convex collision generation for scenes feat: generate collision shapes from mesh via the PendingConvexCollision component (behind the collision-from-mesh feature flag) Feb 19, 2022
@jcornaz jcornaz merged commit 086a6a6 into jcornaz:main Feb 19, 2022
@Shatur Shatur deleted the pending-collision branch February 19, 2022 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants